Skip to content

Migrate Aks from wyunchi-ms-patch-3 to wyunchi-ms-patch-2#24256

Closed
azure-powershell-bot wants to merge 1 commit intowyunchi-ms-patch-2from
codegen/Aks
Closed

Migrate Aks from wyunchi-ms-patch-3 to wyunchi-ms-patch-2#24256
azure-powershell-bot wants to merge 1 commit intowyunchi-ms-patch-2from
codegen/Aks

Conversation

@azure-powershell-bot
Copy link
Collaborator

@azure-powershell-bot azure-powershell-bot commented Feb 27, 2024

Description

Migrate Aks from wyunchi-ms-patch-3 to wyunchi-ms-patch-2
The last commit of src/Aks in wyunchi-ms-patch-3 is:
commit 0faaaad Author: NanxiangLiu 33285578+Nickcandy@users.noreply.github.com Date: Thu Jan 25 09:34:49 2024 +0800 Fixed the resolve path issue in Install-AzAksCliTool. [#22853] (#24032)

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 27, 2024 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Aks
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
❌ Disable-AzAksAddOn 1 1 Capitalization_Conventions_Violated Disable-AzAksAddon doesn't follow the Capitalization Conventions. Disable-AzAksAddon -Name HttpApplicationRouting,Monitoring,AzurePolicy,VirtualNode,KubeDashboard Check the Capitalization Conventions. Suggest format: Disable-AzAksAddOn
❌ Enable-AzAksAddOn 1 1 Capitalization_Conventions_Violated Enable-AzAksAddon doesn't follow the Capitalization Conventions. Enable-AzAksAddon -Name HttpApplicationRouting,Monitoring,AzurePolicy,VirtualNode,KubeDashboard -WorkspaceResourceId xxxxx/xxxx -SubnetName subnet Check the Capitalization Conventions. Suggest format: Enable-AzAksAddOn
⚠️ Get-AzAksManagedClusterOutboundNetworkDependencyEndpoint 1 2 Is_Alias select is an alias of 'Select-Object'. select Category,Endpoint Use formal name 'Select-Object' of the alias 'select'.
⚠️ Invoke-AzAksRunCommand 1 1 Unassigned_Variable Invoke-AzAksRunCommand -ResourceGroupName $resourceGroup is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroup.
⚠️ Invoke-AzAksRunCommand 1 1 Unassigned_Variable Invoke-AzAksRunCommand -Name $clusterName is a null-valued parameter value. -Name Assign value for $clusterName.
⚠️ Set-AzAksClusterCredential 1 1 Unassigned_Variable ConvertTo-SecureString -[-String] $password is a null-valued parameter value. $password Assign value for $password.
⚠️ Set-AzAksClusterCredential 1 3 Unassigned_Variable Set-AzAksClusterCredential -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ Set-AzAksClusterCredential 1 3 Unassigned_Variable Set-AzAksClusterCredential -Name $Name is a null-valued parameter value. -Name Assign value for $Name.
❌Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
❌ Disable-AzAksAddOn 1 1 Capitalization_Conventions_Violated Disable-AzAksAddon doesn't follow the Capitalization Conventions. Disable-AzAksAddon -Name HttpApplicationRouting,Monitoring,AzurePolicy,VirtualNode,KubeDashboard Check the Capitalization Conventions. Suggest format: Disable-AzAksAddOn
❌ Enable-AzAksAddOn 1 1 Capitalization_Conventions_Violated Enable-AzAksAddon doesn't follow the Capitalization Conventions. Enable-AzAksAddon -Name HttpApplicationRouting,Monitoring,AzurePolicy,VirtualNode,KubeDashboard -WorkspaceResourceId xxxxx/xxxx -SubnetName subnet Check the Capitalization Conventions. Suggest format: Enable-AzAksAddOn
⚠️ Get-AzAksManagedClusterOutboundNetworkDependencyEndpoint 1 2 Is_Alias select is an alias of 'Select-Object'. select Category,Endpoint Use formal name 'Select-Object' of the alias 'select'.
⚠️ Invoke-AzAksRunCommand 1 1 Unassigned_Variable Invoke-AzAksRunCommand -ResourceGroupName $resourceGroup is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroup.
⚠️ Invoke-AzAksRunCommand 1 1 Unassigned_Variable Invoke-AzAksRunCommand -Name $clusterName is a null-valued parameter value. -Name Assign value for $clusterName.
⚠️ Set-AzAksClusterCredential 1 1 Unassigned_Variable ConvertTo-SecureString -[-String] $password is a null-valued parameter value. $password Assign value for $password.
⚠️ Set-AzAksClusterCredential 1 3 Unassigned_Variable Set-AzAksClusterCredential -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ Set-AzAksClusterCredential 1 3 Unassigned_Variable Set-AzAksClusterCredential -Name $Name is a null-valued parameter value. -Name Assign value for $Name.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Aks. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Aks. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@wyunchi-ms wyunchi-ms closed this Feb 27, 2024
@wyunchi-ms wyunchi-ms deleted the codegen/Aks branch April 23, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azure-powershell-bot @wyunchi-ms